Open
Conversation
salni84
commented
Oct 20, 2020
salni84
commented
- Exceptions werden dort behandelt wo die Methoden aufgerufen werden. (getActualValue())
- Alle anderen funktionalen Methoden sind frei von Fehlerhandling
- Kommentare gelöscht
- Und noch ein wenig refactoring ;-)
added 3 commits
October 20, 2020 17:16
ideadapt
reviewed
Oct 20, 2020
| throw new ReadWriteException("Not possible to read protocol-type: " + protocol); | ||
| } | ||
|
|
||
| }catch (ParserConfigurationException | IOException | SAXException e) { |
Owner
There was a problem hiding this comment.
die exceptions sollten so lokal, d.h. so nahe am Erzeuger wie möglich, catched werden. das war vor deinen changes eher der fall ... :)
weil: Jetzt hast du in einer abstrakten Methode getActualValue sehr technische Exceptions-Catches drin, die stark von der Implementierung der einzelnen Protokolle abhängig sind. Das ist nicht gut (eine Form von "mixed levels of abstraction" Code Smell, oder auch Verletzung von information hiding).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.